internal: (studio) do not record events if cloud studio is enabled #31858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astone123
commented
Jun 10, 2025
| @@ -853,7 +864,7 @@ export const useStudioStore = defineStore('studioRecorder', { | |||
| return $el.hasClass('__cypress-studio-assertions-menu') | |||
| }, | |||
|
|
|||
| _openAssertionsMenu (event) { | |||
| _openAssertionsMenu (event, addAssertion?: ($el: HTMLElement | JQuery<HTMLElement>, ...args: AssertionArgs) => void) { | |||
There was a problem hiding this comment.
adding the ability to pass in addAssertion here allows us to control assertion recording from the cloud without having to move the whole assertion menu UI over - see the other PR for how we hook into this
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
studio-cloud-listeners
|
| Run status |
|
| Run duration | 19m 29s |
| Commit |
|
| Committer | astone123 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
16
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32183
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.56%
|
|
|---|---|
|
Untested elements
|
191
|
|
Tested elements
|
164
|
Accessibility
92.74%
|
|
|---|---|
|
Failed rules
|
3 critical
9 serious
2 moderate
2 minor
|
|
Failed elements
|
695
|
| @@ -269,6 +269,8 @@ useSubscription({ query: StudioStatus_ChangeDocument }, (_, data) => { | |||
| }) | |||
|
|
|||
| const cloudStudioRequested = computed(() => { | |||
There was a problem hiding this comment.
Cool! I think I need this for cy.prompt actually.
ryanthemanuel
approved these changes
Jun 12, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
For this ticket, we're moving all of the AUT event listener logic over to the cloud studio side. This PR updates the app so that if we're in cloud studio mode, we don't add the event listeners for current studio, since that would result in duplicate event listeners being added.
See related Cloud PR https://github.com/cypress-io/cypress-services/pull/10939
Steps to test
Test the cloud PR and make sure that when running with current studio you can still record commands
How has the user experience changed?
Both studio experiences should remain the same from a user's perspective.
PR Tasks